Opened on 07/16/2014 at 12:17:52 PM

Closed on 07/17/2014 at 09:13:06 AM

Last modified on 07/31/2014 at 08:37:32 AM

#1050 closed change (fixed)

Create utils project with shared files

Reported by: sergz Assignee: sergz
Priority: P4 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):



Previously they were included into each project.

Some benefits from it:

  • DRY, it's already used by AdblockPlus, AdblockplusEngine and by tests
  • Less compilation time.
  • Theoretically it can happen that in tests there are some defines which change the code. Linking the same library we have the tested code.
  • No repeating - less disorder.
  • Also one have to be sure that it's compilable in all projects instead of in only one.

What to change

The gyp file from which the project is generated.

Attachments (0)

Change History (3)

comment:1 Changed on 07/16/2014 at 01:32:46 PM by sergz

  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
  • Owner set to sergz
  • Priority changed from Unknown to P4
  • Review URL(s) modified (diff)

comment:2 Changed on 07/17/2014 at 09:13:06 AM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed on 07/31/2014 at 08:37:32 AM by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.2

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.