Opened on 08/07/2014 at 02:26:47 PM

Closed on 11/17/2015 at 07:18:33 PM

#1184 closed change (fixed)

[meta] Installer cleanup

Reported by: fhd Assignee: eric@…
Priority: P2 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: meta installer
Cc: Blocked By: #1185, #1186, #1187, #1984
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)


The current installer code has been committed without review. We need to review the changes and create issues for all the things we need to clean up.

What to change

Ticket Status Resolution Summary Component Owner
#1185 closed fixed [Installer cleanup] Make code formatting and indentation comply with our coding style Adblock-Plus-for-Internet-Explorer eric@…
#1186 closed fixed [Installer cleanup] Make the naming comply with our coding style Adblock-Plus-for-Internet-Explorer
#1187 closed fixed [Installer cleanup] Do not leak MSIHANDLEs in custom action Adblock-Plus-for-Internet-Explorer
#1984 closed fixed Do not use VBScript in installer build tools Adblock-Plus-for-Internet-Explorer oleksandr

Attachments (0)

Change History (13)

comment:1 Changed on 08/07/2014 at 02:27:41 PM by fhd

  • Description modified (diff)

comment:2 Changed on 08/07/2014 at 02:37:08 PM by fhd

  • Blocked By 1185 added

comment:3 Changed on 08/07/2014 at 02:50:27 PM by fhd

  • Blocked By 1186 added

comment:4 Changed on 08/08/2014 at 09:05:08 AM by oleksandr

  • Blocked By 1187 added

comment:5 Changed on 08/08/2014 at 05:39:29 PM by fhd

  • Blocked By 1189 added

comment:6 Changed on 08/14/2014 at 02:04:07 PM by fhd

  • Keywords installer added

comment:7 Changed on 09/30/2014 at 08:31:48 AM by fhd

  • Blocked By 1189 removed

comment:8 Changed on 09/30/2014 at 08:37:03 AM by fhd

  • Priority changed from P3 to P2

Increasing priority - we should tackle this before the other installer issues.

comment:9 Changed on 01/15/2015 at 11:20:09 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:10 Changed on 01/16/2015 at 09:01:08 AM by oleksandr

  • Owner set to eric@…

comment:11 Changed on 02/17/2015 at 11:44:25 PM by oleksandr

  • Blocked By 1984 added

comment:12 Changed on 02/19/2015 at 08:38:35 AM by oleksandr

  • Milestone Adblock-Plus-for-Internet-Explorer-1.4 deleted

comment:13 Changed on 11/17/2015 at 07:18:33 PM by

  • Resolution set to fixed
  • Status changed from new to closed
  • Tester set to Unknown

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from eric@….
Note: See TracTickets for help on using tickets.