Opened on 08/07/2014 at 02:37:08 PM
Closed on 10/29/2015 at 05:16:52 PM
Last modified on 11/21/2016 at 10:44:08 AM
#1185 closed change (fixed)
[Installer cleanup] Make code formatting and indentation comply with our coding style
| Reported by: | fhd | Assignee: | eric@… |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | installer |
| Cc: | Blocked By: | ||
| Blocking: | #1184 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by fhd)
Background
See #1184.
What to change
The installer specific code is pretty far from our coding style currently, we should make the code formatting consistent with it. The main issues seem to be spaces in parentheses and before semicolons, and sometimes tabs instead of spaces for indentation.
Attachments (0)
Change History (13)
comment:1 Changed on 08/07/2014 at 02:37:50 PM by fhd
- Description modified (diff)
- Summary changed from [Installer cleanup] Fix indentation and whitespace issues to [Installer cleanup] Fix code formatting and indentation
comment:2 Changed on 08/07/2014 at 02:50:15 PM by fhd
- Summary changed from [Installer cleanup] Fix code formatting and indentation to [Installer cleanup] Make code formatting and indentation comply with our coding style
comment:3 Changed on 08/07/2014 at 03:46:05 PM by eric@adblockplus.org
comment:4 Changed on 08/08/2014 at 05:39:29 PM by fhd
- Blocking 1189 added
comment:5 Changed on 08/14/2014 at 02:04:21 PM by fhd
- Keywords installer added
comment:6 Changed on 09/30/2014 at 08:31:48 AM by fhd
- Blocking 1189 removed
comment:7 Changed on 09/30/2014 at 08:37:03 AM by fhd
- Priority changed from P3 to P2
Increasing priority - we should tackle this before the other installer issues.
comment:8 Changed on 01/15/2015 at 11:20:55 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
comment:9 Changed on 01/16/2015 at 09:02:27 AM by oleksandr
- Owner set to eric@…
comment:10 Changed on 02/19/2015 at 08:37:57 AM by oleksandr
- Milestone Adblock-Plus-for-Internet-Explorer-1.4 deleted
comment:11 Changed on 10/29/2015 at 04:36:24 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
- Tester set to Unknown
comment:12 Changed on 10/29/2015 at 05:16:52 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from new to closed
comment:13 Changed on 11/21/2016 at 10:44:08 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See
TracTickets for help on using
tickets.
I've used Artistic Style to convert my personal coding style (that's what present in the code base now) to be more in conformance with the ABP style.
http://astyle.sourceforge.net/
One caveat. It doesn't handle spaces before and after square brackets.