Opened on 10/18/2014 at 07:15:31 AM
Closed on 09/30/2016 at 12:46:58 PM
Last modified on 09/30/2016 at 01:09:20 PM
#1483 closed change (fixed)
sitescripts.extensions.utils.getDownloadLinks() shouldn't fail completely for issues in one repository
| Reported by: | trev | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | sebastian, jsonesen | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
sitescripts.extensions.web.downloads stopped updating its links recently, I had to restart the process. Recently there were issues connecting to AMO servers, and it seems that the resulting exception killed the update thread.
What to change
sitescripts.extensions.utils.getDownloadLinks() should never fail - if one repository has issues, it should print the exception but continue with the next repository.
Attachments (0)
Change History (12)
comment:1 Changed on 02/19/2015 at 01:40:49 PM by sebastian
- Component changed from Infrastructure to Sitescripts
comment:2 Changed on 04/17/2015 at 10:56:40 AM by sebastian
- Cc sebastian added
- Priority changed from P1 to P2
comment:3 Changed on 03/18/2016 at 10:12:08 AM by andrey
comment:4 Changed on 03/18/2016 at 10:33:55 AM by trev
- Tester set to Unknown
Yes, just use logging module.
comment:5 follow-up: ↓ 6 Changed on 05/13/2016 at 08:28:34 AM by sebastian
It seems the current code in the updater thread already catches all exceptions:
try:
links = _get_links()
except:
traceback.print_exc()
(Though, it wouldn't continue with the next repo if an error occurs. But simply retries all repos after 10 minutes.)
comment:6 in reply to: ↑ 5 Changed on 05/13/2016 at 12:07:53 PM by trev
Replying to sebastian:
(Though, it wouldn't continue with the next repo if an error occurs. But simply retries all repos after 10 minutes.)
That's still a problem - if one repo has persistent errors others will never update.
However, my initial assessment of the issue is probably incorrect, the exception catching code was there all along.
comment:7 Changed on 05/17/2016 at 04:01:33 PM by sebastian
- Ready unset
No objections to change the code that it continues with the next repo if one fails. However, if you had to restart the process last time, to make it work again, that was a different issue. And with the given information, I have no idea what might have caused it. Anyway, feel free to update the issue description.
comment:8 Changed on 09/01/2016 at 09:55:04 AM by jsonesen
Is this someone working on this? Otherwise I am happy to do so.
comment:9 Changed on 09/01/2016 at 10:11:50 AM by trev
- Description modified (diff)
- Ready set
- Summary changed from sitescripts.extensions.utils.getDownloadLinks() should never fail to sitescripts.extensions.utils.getDownloadLinks() shouldn't fail completely for issues in one repository
Feel free to. I changed the description, now this is about error handling - if we have persistent errors affecting one repository, it shouldn't have any effect on others.
comment:10 Changed on 09/30/2016 at 09:24:56 AM by jsonesen
- Cc jsonesen added
- Owner set to jsonesen
comment:11 Changed on 09/30/2016 at 12:46:58 PM by jsonesen
- Resolution set to fixed
- Status changed from new to closed
comment:12 Changed on 09/30/2016 at 01:09:20 PM by abpbot
A commit referencing this issue has landed:
Issue 1483 - Add exception handling so if one repo has errors others are not affected
Where should it print? STDERR?