Opened on 11/25/2014 at 04:29:21 PM

Closed on 11/26/2014 at 11:38:51 AM

Last modified on 01/07/2015 at 10:41:04 AM

#1606 closed defect (fixed)

"Block element" injects overlays for hidden elements

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6463903206735872

Description

How to reproduce

  1. Go to ​http://www.w3schools.com/html/html5_video.asp
  2. Click ABP icon
  3. Choose "Block element"

Observed behaviour

You see a couple of overlays placed in the upper left corner. Those overlays have been created for hidden elements (style="display: none;"). Hence the content covered by those overlays don't match the elements they were created for.

Expected behaviour

No overlays should be created for hidden elements.

Attachments (0)

Change History (5)

comment:1 Changed on 11/25/2014 at 04:30:25 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/26/2014 at 11:38:51 AM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockpluschrome/rev/a0bed98571f7

comment:3 Changed on 11/26/2014 at 05:24:38 PM by sebastian

​https://hg.adblockplus.org/adblockpluschrome/rev/43e00bb173d7

comment:4 Changed on 01/07/2015 at 10:40:08 AM by sebastian

Also see #1124

comment:5 Changed on 01/07/2015 at 10:41:04 AM by sebastian

Also see #1394

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.