Opened on 03/04/2015 at 07:15:39 PM
Closed on 03/04/2015 at 09:53:25 PM
#2084 closed defect (fixed)
Placeholders show up in dynamically created frames
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Environment
Chrome and Opera, not in Safari
Adblock Plus 1.8.10 and current devbuild
EasyList Germany + Acceptable Ads
How to reproduce
- Go to http://www.chip.de/News_29559209.html
- Scroll down to the blocked ad banners
Observed behaviour
Placeholder show up, where the ad banners were. That is because the surrounding frame is dynamically created. Those frames are usually considered, but the way those particular frames are created here contentDocument.location is the top-level URL instead about:blank, bypassing our detection. This is a regression introduced with #1977, where that detection has been adjusted to fix another bug.
Expected behaviour
No placeholders for blocked elements should show up.
Attachments (0)
Change History (2)
comment:1 Changed on 03/04/2015 at 07:20:11 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/04/2015 at 09:53:25 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/39d19d26b751