Opened on 03/25/2015 at 02:45:37 PM

Closed on 03/27/2015 at 09:27:54 AM

#2216 closed change (fixed)

Run content scripts again in about:blank frames

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #2217 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5407608865292288

Description (last modified by sebastian)

Background

With #1704 we stopped using the ​match_about_blank option for content scripts, due to some Chrome bugs. However, this caused some issues with the "Block element" dialog (#1792, #2207).

What to change

Add the match_about_blank option for content scripts on Chrome again.

Attachments (0)

Change History (4)

comment:1 Changed on 03/25/2015 at 02:53:02 PM by sebastian

  • Description modified (diff)
  • Summary changed from Run content scripts again in about:blank frames on Chrome 37+ to Run content scripts again in about:blank frames

comment:2 Changed on 03/25/2015 at 03:14:45 PM by sebastian

  • Blocking 2217 added

comment:3 Changed on 03/25/2015 at 03:17:07 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/27/2015 at 09:27:54 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/buildtools/rev/c4590ad32b6e

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.