Opened on 04/22/2015 at 01:06:23 PM

Closed on 03/16/2016 at 03:24:02 PM

#2400 closed change (worksforme)

Implement Firefox-specific changes to the CSS property rules content script

Reported by: trev Assignee:
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By: #2395
Blocking: #2398 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

The content script created in #2395 will only work correctly in Chrome and Safari.

What to change

Implement Firefox-specific changes to the content script, in particular inject the stylesheet as a user stylesheet that isn't visible to the page.

Attachments (0)

Change History (4)

comment:1 Changed on 04/22/2015 at 01:10:04 PM by trev

  • Blocking 2401 added

comment:2 Changed on 03/16/2016 at 03:15:25 PM by trev

  • Blocking 2401 removed
  • Tester set to Unknown

This isn't really blocking integration of the content script in Firefox.

comment:3 Changed on 03/16/2016 at 03:15:48 PM by trev

  • Component changed from Adblock-Plus-for-Firefox to Core

comment:4 Changed on 03/16/2016 at 03:24:02 PM by trev

  • Resolution set to worksforme
  • Status changed from new to closed

Actually, this is no longer necessary - addSelectorsFunc is being passed to CSSPropertyFilters constructor, this one isn't part of the content script and should implement Firefox-specific functionality.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.