Opened on 04/22/2015 at 01:10:04 PM
Closed on 03/31/2016 at 11:06:54 AM
Last modified on 04/22/2016 at 02:09:52 AM
#2401 closed change (fixed)
Integrate CSS property rule handling in Firefox
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7.3-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | #2396, #3499, #3813, #3834, #3835, #3837, #3960 | |
| Blocking: | #2398 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29338602/ |
||
Description
Background
Once all the necessary mechanisms are in place, we still need code to make sure the content script for CSS property rules is applied.
What to change
Update adblockplusui dependency in order to use the latest messageResponder.js version. Add code to listen to new documents being created, inject the content script into any pages having CSS property rules associated with them.
Attachments (0)
Change History (16)
comment:1 Changed on 03/16/2016 at 03:14:47 PM by trev
- Blocked By 3499 added; 2399 removed
- Tester set to Unknown
comment:2 Changed on 03/16/2016 at 03:15:25 PM by trev
- Blocked By 2400 removed
comment:3 Changed on 03/16/2016 at 03:17:16 PM by trev
- Blocked By 3813 added
comment:4 Changed on 03/16/2016 at 05:32:56 PM by trev
- Owner set to trev
comment:6 Changed on 03/18/2016 at 11:46:29 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluscore/rev/9dbbcdc4ff57
comment:7 Changed on 03/18/2016 at 12:05:28 PM by trev
- Blocked By 3834 added
comment:8 Changed on 03/18/2016 at 12:20:30 PM by trev
- Blocked By 3835 added
comment:9 Changed on 03/18/2016 at 12:28:42 PM by trev
- Blocked By 3836 added
comment:10 Changed on 03/18/2016 at 12:29:02 PM by trev
- Blocked By 3836 removed
comment:11 Changed on 03/18/2016 at 02:14:24 PM by trev
- Blocked By 3837 added
comment:12 Changed on 03/18/2016 at 03:25:38 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:13 Changed on 03/31/2016 at 11:05:58 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/a67269ee21f4
comment:14 Changed on 03/31/2016 at 11:06:54 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:15 Changed on 04/20/2016 at 02:04:16 PM by trev
- Blocked By 3960 added
comment:16 Changed on 04/22/2016 at 02:09:52 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
CSS property rules are in the build and usable.
ABP 2.7.2.4166
Firefox 38 / 44 / 45 / Windows 8
Firefox 38 / 44 / OSX 10.11
Firefox 44 / Ubuntu 14.04
Put a tiny change to the content script under review, it won't work correctly in Firefox otherwise. Will create a separate review for the main code shortly.