Opened on 06/22/2015 at 02:15:55 PM
Closed on 12/07/2016 at 09:17:17 PM
Last modified on 03/14/2017 at 11:56:02 AM
#2709 closed change (fixed)
Remove legacy failsafe code form Utils.getString
| Reported by: | sebastian | Assignee: | wspee |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.13-for-Chrome-Opera |
| Module: | Platform | Keywords: | goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
The function Utils.getString() returns the translation for strings imported from Adblock Plus for Firefox. Therefore it relies on ext.i18n.getMessage, and simply returns the message id, if ext.i18n isn't available. However, ext.i18n is always available (now), and this check is obsolete.
What to change
Remove the check for ext.i18n from Utils.getString in lib/utils.js.
Attachments (0)
Change History (6)
comment:1 Changed on 12/05/2016 at 04:12:19 PM by wspee
- Owner set to wspee
- Tester set to Unknown
comment:2 Changed on 12/05/2016 at 04:12:26 PM by wspee
- Status changed from new to reviewing
comment:4 Changed on 12/07/2016 at 05:13:05 PM by abpbot
comment:5 Changed on 12/07/2016 at 09:17:17 PM by wspee
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 03/14/2017 at 11:56:02 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Hasn't caused any obvious regressions.
ABP 1.12.4.1739
Chrome 49 / 56 / Windows 10
Chrome 56 / OS X 10.12
Chrome 56 / Ubuntu 16.04
Opera 37 / 41 / Windows 7
Safari 10 / OS X 10.12
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 2709 - Removed legacy failsafe code form Utils.getString