Opened on 09/08/2015 at 11:59:52 AM

Closed on 09/08/2015 at 12:37:55 PM

#3014 closed change (rejected)

Make base path used in icons module configurable

Reported by: kzar Assignee: kzar
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29326108/

Description

Background

Currently adblockpluschrome/lib/icon.js uses the base path of icons/abp-$size for icons and it is not configurable.

What to change

Export and use a basePath variable from the icon module that has the default value of "icons/abp-$size". That way it can be overridden from outside the module when required.

Attachments (0)

Change History (2)

comment:1 Changed on 09/08/2015 at 12:02:50 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/08/2015 at 12:37:55 PM by kzar

  • Resolution set to rejected
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.