Opened on 09/08/2015 at 01:35:43 PM

Closed on 09/09/2015 at 05:11:24 AM

#3015 closed change (fixed)

Remove legacy code for Adblock Browser iOS email notifcation

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By: #3013
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29326122

Description (last modified by sebastian)

Background

With #2234 we added a WSGI app to sign up with your email address to be notified when Adblock Browser for iOS is available. Adblock Browser has just been released. But with #2846, the WSGI app has been extended to be reused for the Microsoft Edge landing page. However, there are some Adblock Browser specific bits in there, that can be removed as soon as the old landing page is gone by #3013.

What to change

Remove Adblock Browser specific code from the submit_email module, the corresponding email template and the related entries in .sitescripts.example.

Attachments (0)

Change History (3)

comment:1 Changed on 09/08/2015 at 01:37:01 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/08/2015 at 01:38:30 PM by sebastian

  • Description modified (diff)

comment:3 Changed on 09/09/2015 at 05:11:24 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/sitescripts/rev/617a3e730050

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.