Opened on 11/02/2015 at 11:12:21 AM

Closed on 11/11/2015 at 07:50:00 AM

Last modified on 11/16/2015 at 11:50:38 AM

#3254 closed change (fixed)

Anti-adblock warning should not show when Adblock Plus is disabled

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.6.12-for-Firefox
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29329604/
​https://codereview.adblockplus.org/29329776/

Description

Background

Anti-adblock notification will currently show up even if Adblock Plus is disabled, this makes no sense.

What to change

Make antiadblockInit check Prefs.enabled and verify that the site isn't whitelisted.

Attachments (0)

Change History (8)

comment:1 Changed on 11/02/2015 at 11:54:18 AM by trev

  • Status changed from new to reviewing

comment:2 Changed on 11/02/2015 at 11:54:24 AM by trev

  • Owner set to trev

comment:3 Changed on 11/02/2015 at 11:54:54 AM by trev

  • Review URL(s) modified (diff)

comment:4 Changed on 11/02/2015 at 02:37:12 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/c4ffcee891c3

comment:5 Changed on 11/05/2015 at 07:20:37 PM by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening: the patch fails to consider that nsIURI.host can throw.

comment:6 Changed on 11/05/2015 at 07:26:31 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:7 Changed on 11/11/2015 at 07:50:00 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed the issue: ​https://hg.adblockplus.org/adblockplus/rev/4c0a0f1b9437

comment:8 Changed on 11/16/2015 at 11:50:38 AM by trev

  • Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-2.6.12-for-Firefox

Adblock Plus 2.6.12 is being released from branch, this change is part of it.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.