Opened on 04/16/2014 at 10:21:38 AM
Closed on 04/16/2014 at 10:38:08 AM
Last modified on 05/15/2014 at 03:09:40 PM
#338 closed defect (fixed)
Adblock Plus isn't compatible with Chrome 19 anymore
| Reported by: | sebastian | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | trev, smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Currently we require Chrome >= 19 as given in by the generated manifest.json when installing Adblock Plus. However we rely on following API changes that were introduced later:
- We use an object in order to configure browserAction icons for different sizes, which isn't possible before Chrome 23.
- We rely on sender.url in the chrome.runtime.onMessage listener, which was first added in Chrome 28.
So we have to update the minimum compatible version to Chrome 28. And can completely remove legacy code for supporting older versions of Chrome.
Attachments (0)
Change History (5)
comment:1 Changed on 04/16/2014 at 10:21:56 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/16/2014 at 10:29:45 AM by mapx
- Cc smultron45@gmail.com added
comment:3 Changed on 04/16/2014 at 10:38:08 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 04/16/2014 at 10:50:06 AM by trev
comment:5 Changed on 05/15/2014 at 03:09:40 PM by sebastian
- Ready set
Note: See
TracTickets for help on using
tickets.
Commit URL was https://hg.adblockplus.org/adblockpluschrome/rev/441b9940b1d7.