Opened on 01/07/2016 at 05:07:39 PM
Closed on 01/08/2016 at 10:13:36 PM
Last modified on 01/18/2016 at 01:42:55 AM
#3486 closed change (fixed)
Don't access content window in issue reporter
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s |
| Cc: | Blocked By: | #3375 | |
| Blocking: | #3494 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29333308/ |
||
Description
Background
With #3375 fixed Issue Reporter most access to the content window parameter is gone, it's mostly being used in order to retrieve the outer window ID. This parameter needs to be removed completely for the code to be fully compatible to E10S.
What to change
Replace wnd dialog parameter by outerWindowID. Delegate scanning frames to the dataCollector module. Reload current page by reloading the tab (needs additional parameter?).
Attachments (0)
Change History (8)
comment:1 Changed on 01/07/2016 at 05:07:54 PM by trev
- Keywords e10s added
comment:2 Changed on 01/07/2016 at 07:01:32 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 01/07/2016 at 07:16:08 PM by trev
- Review URL(s) modified (diff)
Second part, improved page reloading.
comment:4 Changed on 01/07/2016 at 07:31:05 PM by trev
- Review URL(s) modified (diff)
Third part, checking for private browsing in content process.
comment:5 Changed on 01/07/2016 at 07:33:21 PM by trev
- Review URL(s) modified (diff)
Final part, removing content window access altogether.
comment:6 Changed on 01/08/2016 at 04:43:24 PM by trev
- Blocking 3494 added
comment:7 Changed on 01/08/2016 at 10:13:36 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 01/18/2016 at 01:42:55 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Issue reporter is behaving correctly.
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64
First part is under review, frame scanning in content process.