Opened on 01/07/2016 at 06:39:52 PM

Closed on 03/03/2017 at 10:25:41 AM

#3487 closed change (fixed)

Finish Help tab of new options page

Reported by: greiner Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords: 2016q1, new-settings-page
Cc: saroyanm Blocked By: #2734
Blocking: #2706 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29373674/

Description (last modified by saroyanm)

Background

In #1526 we were creating the very first version of the Help tab but there are still some changes that need to be made to finish this part of the page.

What to change

  • Implement links
    • "Frequently asked questions" should link to "faq" page
    • "Adblock Plus support forum" should link to "info.application_support" page
    • "Twitter" should link to "social_twitter"
    • "Facebook" should link to "social_facebook"
    • "Google+" should link to "social_gplus"
    • "Weibo" should link to "social_weibo"
    • "Renren" should link to "social_renren"
  • Make sure to show only relevant social media links depending on the language (as implemented in firstRun.css)

Attachments (0)

Change History (8)

comment:1 Changed on 02/01/2016 at 04:22:41 PM by sebastian

  • Keywords 2016q1 added

comment:2 Changed on 01/24/2017 at 11:47:48 AM by saroyanm

  • Description modified (diff)
  • Keywords new-settings-page added

We will not have link to the forum in the Help tab according to the new desing, other links still will be reusable.

comment:3 Changed on 01/24/2017 at 12:01:29 PM by saroyanm

  • Cc saroyanm added

comment:4 Changed on 01/25/2017 at 11:52:37 AM by saroyanm

  • Description modified (diff)

We still need link to the forum.

comment:5 Changed on 01/27/2017 at 03:36:38 PM by saroyanm

  • Owner set to saroyanm

comment:6 Changed on 01/27/2017 at 05:24:34 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 03/03/2017 at 10:24:12 AM by abpbot

A commit referencing this issue has landed:
Issue 3487 - Add links to the help tab

comment:8 Changed on 03/03/2017 at 10:25:41 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.