Opened on 03/03/2016 at 11:24:19 AM
Closed on 11/30/2018 at 02:01:47 PM
Last modified on 10/08/2019 at 05:46:16 PM
#3725 closed change (rejected)
Implement Notifications
| Reported by: | rjeschke | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | mario, fhd, tpregueiro | Blocked By: | #6238 |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
As the title says. Notifications weren't part of the first draft.
Attachments (0)
Change History (8)
comment:1 Changed on 10/17/2017 at 09:36:14 AM by jwangenheim
- Cc mario fhd added
comment:2 Changed on 10/17/2017 at 01:53:19 PM by fhd
There are multiple types of notifications. Ideally we support all types on all platforms. But we need to support at the very least emergency notifications on all platforms. See https://bitbucket.org/adblockplus/spec/src/7a0f1650ecd7e92067e4114a787b51dd45a9e012/spec/abp/notifications.md?at=master&fileviewer=file-view-default#markdown-header-notification-types
comment:3 follow-up: ↓ 4 Changed on 10/19/2017 at 09:29:06 AM by jwangenheim
Then I probably misunderstood you and we should keep the ticket and extend it a little more. By emergency you mean the type which is referred to as "Critical" or "Relentless"?
As far as I can see, we don't have any designs for notifications for mobile yet, right? It would be good if we had at least a wireframe prototype to start working on that issue.
Maybe we can discuss this later in the Android Developer meeting.
comment:4 in reply to: ↑ 3 Changed on 10/19/2017 at 11:46:26 AM by fhd
- Cc tpregueiro added
Replying to jwangenheim:
Then I probably misunderstood you and we should keep the ticket and extend it a little more. By emergency you mean the type which is referred to as "Critical" or "Relentless"?
Just "Critical" is sufficient for starters. All the others are nice to have.
As far as I can see, we don't have any designs for notifications for mobile yet, right? It would be good if we had at least a wireframe prototype to start working on that issue.
Maybe we can discuss this later in the Android Developer meeting.
Yeah, we have no real idea of how to show notifications yet. I've looped in Tiago so he can think about it.
comment:5 Changed on 01/09/2018 at 10:40:31 AM by mario
- Blocked By 6238 added
comment:6 Changed on 08/21/2018 at 06:24:26 AM by johnson83
spam
comment:7 Changed on 11/30/2018 at 02:01:47 PM by mario
- Resolution set to rejected
- Status changed from new to closed
Closed as the ticket has been moved over to GitLab.
https://gitlab.com/eyeo/adblockplus/adblockplussbrowser/issues/7
comment:8 Changed on 06/01/2019 at 02:47:36 AM by uw777
spam
@mario
I talked about this issue with @fhd a while ago and he said that we will use notifications only for cross product promotion with ABB and ABP for desktop. I think this ticket can be closed because it's only a draft anyway.