Opened on 03/03/2016 at 11:25:15 AM
Closed on 10/17/2017 at 09:49:58 AM
#3726 closed change (rejected)
Make AntiAdblock filter list a default
| Reported by: | rjeschke | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | greiner, fhd, mario | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
As the title says. Anti Adblock filters are currently not enabled by default.
Attachments (0)
Change History (5)
comment:1 Changed on 03/04/2016 at 11:22:34 AM by greiner
- Cc greiner added
comment:2 Changed on 03/04/2016 at 02:53:42 PM by philll
- Cc fhd added
comment:3 Changed on 03/04/2016 at 03:02:03 PM by fhd
Yes, this should be opt-in, as on desktop. I really don't think we want to duplicate the logic for that (SBrowser has currently replicated selected parts of the core code rather than using libadblockplus). So I'd just leave it as an option for the user for now.
comment:4 Changed on 10/17/2017 at 09:33:01 AM by jwangenheim
- Cc mario added
@mario
Regarding the comments (which are nearly 2 years old by now) and the status that the list is still opt-in - can we close this ticket?
comment:5 Changed on 10/17/2017 at 09:49:58 AM by mario
- Resolution set to rejected
- Status changed from new to closed
Agreed, closing it for now for the reasons stated above.
As pointed out previously we could think of asking the user whether they want to enable the filter list as soon as a filter hits, but that is an entirely different story (and potentially not even possible with Samsung Internet unless they extend their API). I'll bring it up with Tiago to evaluate whether that'd be beneficial and file a separate issue as soon as it has been decided and as soon as Samsung has enabled us to implement a feature like that.
I strongly doubt we want to have this list enabled by default. We should rather preload it and ask the user about enabling it when something matched. Not sure this is even possible with SBrowser.