Opened on 03/07/2016 at 01:08:36 PM
Closed on 06/24/2016 at 05:12:18 PM
Last modified on 10/08/2019 at 05:46:19 PM
#3741 closed change (fixed)
Add "remove" option to list items in new options page
| Reported by: | greiner | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | athornburgh, saroyanm, sebastian | Blocked By: | |
| Blocking: | #2355 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
It is non-obvious what effects checking or unchecking a checkbox has on the item. Therefore we should add a "remove" option to removable list items.
Furthermore, the "popular" label is misleading and should be removed since it doesn't add any value anymore.
See also the design mockup.
What to change
- Remove "popular" label from "Further blocking lists" section
- Add "x" button to the right of each removable list item on General tab (see default state, hover state)
- Whitelisted websites section
- Remove "x" button on the left
- Align domains in Whitelisted websites section to the left
Attachments (3)
Change History (13)
Changed on 03/07/2016 at 01:14:35 PM by greiner
Changed on 03/07/2016 at 01:14:48 PM by greiner
Changed on 03/07/2016 at 01:14:56 PM by greiner
comment:2 Changed on 03/07/2016 at 01:19:21 PM by greiner
- Blocking 2355 added
- Cc athornburgh saroyanm sebastian added
- Priority changed from Unknown to P2
- Ready set
comment:3 follow-up: ↓ 4 Changed on 03/15/2016 at 02:02:13 PM by sebastian
comment:4 in reply to: ↑ 3 Changed on 03/15/2016 at 05:10:02 PM by greiner
Replying to sebastian:
We are about to add pre-configurable subscriptions which are supposed to be not removable (#3801). In the old options page you cannot remove subscriptions that are given in Prefs.additional_subscriptions. So we have to account for that here as well.
In that case it might make sense to reintroduce the labelling of filter lists (formerly known as "popular" label) so that we're transparent about that some of those are recommended by us while others are recommended by the organization.
comment:5 Changed on 03/15/2016 at 05:49:50 PM by sebastian
Well, if there is no label at all, we won't indicate anything wrong, I guess. Also keep in mind that this is quite an edge case; users, whose organization has rolled out Adblock Plus with additional filter subscriptions, coming to the options page. So FWIW, I think treating these subscriptions the same as our suggested subscriptions would be good enough, in particular for the initial release of the new options page.
comment:6 Changed on 03/21/2016 at 10:28:29 AM by saroyanm
- Owner set to saroyanm
comment:7 Changed on 03/23/2016 at 04:47:16 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 06/24/2016 at 05:09:26 PM by abpbot
A commit referencing this issue has landed:
issue 3741 - Add 'remove' option to list items in new options page
comment:9 Changed on 06/24/2016 at 05:12:18 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 05/22/2019 at 06:16:32 AM by ashwink
spam
We are about to add pre-configurable subscriptions which are supposed to be not removable (#3801). In the old options page you cannot remove subscriptions that are given in Prefs.additional_subscriptions. So we have to account for that here as well.