Opened on 03/18/2016 at 12:05:28 PM

Closed on 03/18/2016 at 02:10:36 PM

#3834 closed change (fixed)

Expose URL constructor to modules

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #2401 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29338608/

Description

Background

In #2401 we need to use the URL constructor in a module which isn't exposed yet.

What to change

Use Cu.importGlobalProperties in bootstrap.js in order to import this constructor along with outhers.

Attachments (0)

Change History (3)

comment:1 Changed on 03/18/2016 at 12:12:06 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/18/2016 at 02:10:11 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/buildtools/rev/7cc1fe2eccbe

comment:3 Changed on 03/18/2016 at 02:10:36 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.