Opened on 03/31/2016 at 04:38:21 PM
Closed on 04/01/2016 at 05:30:46 PM
Last modified on 04/03/2016 at 03:20:24 PM
#3882 closed change (fixed)
Make checkbox labels sensitive on the new option page
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, athornburgh | Blocked By: | |
| Blocking: | #2407 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently, clicking the label of any checkbox on the new options page doesn't have any effect. However, users would expect that clicking the label will cause the corresponding checkbox to be toggled, as this is common practice on the web (and for other UIs). Moreover, in particular when using less accurate input devices, it's easier to use checkboxes if the area you can click on is larger (because it includes the label). The old options page accounts for that, so this is a UX regression.
What to change
Toggle the checkboxes on the General tab and the Tweaks section of the Advanced tab when their label is clicked.
Attachments (0)
Change History (6)
comment:1 Changed on 03/31/2016 at 04:39:48 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/31/2016 at 04:41:09 PM by greiner
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 04/01/2016 at 02:39:45 PM by greiner
- Blocking 2407 added
comment:4 Changed on 04/01/2016 at 05:29:17 PM by abpbot
comment:5 Changed on 04/01/2016 at 05:30:46 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 04/03/2016 at 03:20:24 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/0ec5d7010cf3
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/595580acfe7d