Opened on 04/12/2016 at 02:38:01 PM

Closed on 09/22/2016 at 02:29:16 PM

#3919 closed defect (fixed)

Flags are missing for some translations in adblockplus.org

Reported by: saroyanm Assignee: saroyanm
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By: #3920
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339710/

Description (last modified by saroyanm)

Environment

Any browser

How to reproduce

  1. Download web.adblockplus.org repository.
  2. Run test server
  3. Navigate to http://127.0.0.1:5000/en/privacy page
  4. Open language selector drop down
  5. Observe

Observed behaviour

Same flag as for Arabic language is being shown for Greek, Italian, Japanese, Polish and Portuguese languages.

Expected behaviour

Each language has flag associated with the language

Note

This issue doesn't appear in the website yet because we are only making the translation available when at least 30% is translated.

Attachments (0)

Change History (6)

comment:1 Changed on 04/12/2016 at 02:44:39 PM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 04/12/2016 at 05:31:24 PM by saroyanm

  • Blocked By 3920 added
  • Ready unset

Apparently this is only reproducible now locally, because of #3920

comment:3 Changed on 04/13/2016 at 10:44:17 AM by saroyanm

  • Description modified (diff)
  • Ready set

comment:4 Changed on 04/13/2016 at 03:33:04 PM by saroyanm

  • Priority changed from P2 to P3
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 09/22/2016 at 02:28:35 PM by abpbot

A commit referencing this issue has landed:
issue 3919 - Added additional flags

comment:6 Changed on 09/22/2016 at 02:29:16 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.