Opened on 05/06/2014 at 10:19:30 AM

Closed on 09/02/2014 at 08:49:08 AM

Last modified on 09/18/2014 at 12:59:40 PM

#432 closed change (fixed)

Adjust to $sitekey-related changes of the Matcher API (Firefox)

Reported by: trev Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-2.6.5-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #406 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



#431 changes the Matcher API that should make it simpler to implement $sitekey functionality in Firefox.

What to change

Remove Matcher.matchesByKey() call in lib/contentPolicy.js, this check should be covered by the Policy.isWhitelisted() call. This requires verifying the sitekey in advance of course and passing it to that function.

Attachments (0)

Change History (8)

comment:1 Changed on 05/28/2014 at 05:25:48 AM by fhd

  • Priority changed from P1 to P2

comment:2 Changed on 06/20/2014 at 01:55:06 PM by greiner

  • Owner set to greiner

comment:3 Changed on 07/09/2014 at 12:38:11 PM by philll

  • Platform set to Firefox

comment:4 Changed on 07/28/2014 at 02:52:23 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 09/02/2014 at 08:49:08 AM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 09/02/2014 at 02:25:38 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:7 Changed on 09/18/2014 at 12:04:13 PM by trev

  • Blocked By 1381 added

comment:8 Changed on 09/18/2014 at 12:59:40 PM by trev

  • Blocked By 1381 removed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.