Opened on 09/15/2016 at 02:54:00 PM
Last modified on 01/12/2018 at 09:17:44 AM
#4439 new change
Make the feedback link in the Adblock Browser preferences point to about:feedback again
Reported by: | fhd | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Adblock-Browser-for-Android | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #4174 | Platform: | Adblock Browser for Android |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Back in the day, after we had disabled about:feedback, we changed the feedback link under preferences to point to our Google+ beta community (#2354). Later, we replaced this with a redirect (#2479). However, since we reactivated about:feedback, we can revert those changes again.
What to change
Change the target of the settings item Give feedback under Settings -> Adblock Browser back to about:feedback. The code in question should be identical to the upstream (i.e. Mozilla) version again.
Attachments (0)
Change History (5)
comment:1 Changed on 08/08/2017 at 02:57:17 PM by jwangenheim
- Owner set to jwangenheim
comment:2 Changed on 08/09/2017 at 08:22:30 AM by jwangenheim
comment:3 Changed on 08/09/2017 at 08:47:08 AM by fhd
How I understand that bug you linked to, about:feedback itself is not local anymore but pointing to a page hosted on input.mozilla.org. That means that we have to leave this link alone.
It also means that we have to either:
a) Replace about:feedback with a local page.
b) Remove about:feedback, and the mechanism that automatically opens it after a few launches of the app.
But we should create a separate issue for that.
comment:4 Changed on 08/11/2017 at 02:26:35 PM by jwangenheim
- Blocking 4174 added
- Ready unset
comment:5 Changed on 01/12/2018 at 09:17:44 AM by jwangenheim
- Owner jwangenheim deleted
Since Firefox 47 about:feedback was replaced with page hosted on input.moziall.org (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1239513). The url also contains MOZ_UPDATE_CHANNEL and MOZ_APP_VERSION.
@fhd
I guess due to this change, the last sentence in the ticket is not valid anymore and we will just link to about:feedback again?