Opened on 11/30/2016 at 12:31:36 PM
Closed on 11/30/2016 at 01:04:36 PM
Last modified on 03/14/2017 at 11:35:11 AM
#4674 closed defect (fixed)
No character set declared for the popup.html page
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.13-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
How to reproduce
- Install the WebExtension build in Firefox.
- Click the ABP button to open the pop-up.
- Check Browser Console for warnings.
Observed behaviour
A warning is displayed complaining about missing charset declaration in popup.html.
Expected behaviour
No warnings.
Attachments (0)
Change History (6)
comment:1 Changed on 11/30/2016 at 12:34:26 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/30/2016 at 01:03:27 PM by abpbot
comment:3 Changed on 11/30/2016 at 01:04:36 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Priority changed from Unknown to P4
- Ready set
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 01/11/2017 at 02:52:03 PM by Ross
- Tester changed from Unknown to Ross
Done. Warnings are gone and files have been updated to the new format. Should the devtools page be updated too as Dave said before marking this fixed?
ABP 1.12.4.1704
Chrome 49/55 / Windows 7
Firefox 48/50 / Windows 7
comment:5 Changed on 01/12/2017 at 11:47:52 AM by kzar
Good point I forgot to file an issue for that, but I have now with #4792.
comment:6 Changed on 03/14/2017 at 11:35:11 AM by Ross
- Verified working set
Done. Fixed in FF WebEx build as well.
ABP 1.12.4.1741
Firefox 52 / Windows 10
ABP 1.12.4.1739
Chrome 49 / 56 / Windows 10
Chrome 56 / OS X 10.12
Chrome 56 / Ubuntu 16.04
Opera 37 / 41 / Windows 7
Safari 10 / OS X 10.12
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4674 - No character set declared for the popup.html page