Opened on 12/09/2016 at 11:22:45 AM
Closed on 01/17/2017 at 07:00:22 AM
Last modified on 03/13/2017 at 11:25:39 AM
#4722 closed change (fixed)
Increase minimum Chrome version to 49 from 41
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.13-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, trev, wspee | Blocked By: | |
| Blocking: | #4795 | Platform: | Chrome |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29367316/ |
||
Description (last modified by kzar)
Background
As of #4552 we removed JS Hydra. Unfortunately that broke things since Chrome versions lower than 45 don't support arrow functions and versions lower than 49 don't support destructuring.
What to change
- Increase the minimum Chrome version to 49.
- Remove legacy code and workarounds that are no longer required.
Attachments (0)
Change History (13)
comment:1 Changed on 12/09/2016 at 01:42:43 PM by kzar
- Description modified (diff)
- Summary changed from Increase minimum Chrome version to 45 from 41 to Increase minimum Chrome version to 49 from 41
comment:2 Changed on 12/12/2016 at 03:55:54 PM by wspee
- Cc wspee added
comment:3 Changed on 12/13/2016 at 11:09:32 AM by kzar
comment:5 Changed on 12/16/2016 at 01:01:01 PM by abpbot
comment:6 Changed on 12/16/2016 at 01:03:01 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 01/10/2017 at 03:20:30 PM by Ross
- Tester changed from Unknown to Ross
Minimum version change done. Removal of legacy code does not seem to have caused any obvious issues or regressions in Chrome. However it might have in Opera (see #4787).
ABP 1.12.4.1704
Chrome 41/45/48/49/53 / Windows 7
Chrome 41/45/48/49/53 / Windows 10
Chrome 41/45/48/49/53 / OS X 10.10
comment:8 Changed on 01/13/2017 at 08:58:10 AM by kzar
- Blocking 4795 added
comment:9 Changed on 01/13/2017 at 11:29:18 AM by kzar
- Resolution fixed deleted
- Review URL(s) modified (diff)
- Status changed from closed to reopened
(Reopening since I noticed another bit of code that can now be removed.)
comment:10 Changed on 01/13/2017 at 11:29:31 AM by kzar
- Status changed from reopened to reviewing
comment:11 Changed on 01/17/2017 at 06:58:44 AM by abpbot
A commit referencing this issue has landed:
Issue 4722 - Remove old check for Chrome notification API
comment:12 Changed on 01/17/2017 at 07:00:22 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:13 Changed on 03/13/2017 at 11:25:39 AM by Ross
- Verified working set
Done.
ABP 1.12.4.1739
Chrome 43 . 49 / 56 / Windows 10
A commit referencing this issue has landed:
Issue 4722 - Drop support for Chrome 41-48 and remove legacy code