Opened on 08/30/2017 at 05:00:27 PM
Last modified on 09/17/2019 at 12:27:03 PM
#5600 new change
CMS Should extract translations from crowdin even if locale dir does not exist
| Reported by: | jsonesen | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | kvas, sebastian, juliandoucette, rhowell | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by jsonesen)
Background
Currently, the script behaves as though the local repository is the master copy which means that if there are new locales on the crowdin project which have not been added to the repository then the new locale is not synced. Mercurial does not recognize empty directories either so a file must also be placed there.
What to change
Change the CMS translations sync script to unpack new upstream locale directory and translation files
Attachments (0)
Change History (9)
comment:1 Changed on 08/30/2017 at 05:00:54 PM by jsonesen
- Summary changed from CMS Should extract all translations from crowdin even if locale dir does not exist in tip of repo to CMS Should extract translations from crowdin if locale dir does not exist in tip of repo
comment:2 Changed on 08/30/2017 at 05:16:35 PM by kvas
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 09/06/2017 at 01:19:53 PM by jsonesen
- Summary changed from CMS Should extract translations from crowdin if locale dir does not exist in tip of repo to CMS Should extract translations from crowdin even if locale dir does not exist
comment:4 Changed on 11/14/2017 at 09:45:57 PM by jsonesen
- Owner set to jsonesen
- Ready unset
comment:5 Changed on 11/15/2017 at 09:20:00 AM by kvas
- Ready set
comment:6 Changed on 12/22/2017 at 12:37:10 PM by jsonesen
- Cc kzar added
comment:7 follow-up: ↓ 8 Changed on 12/22/2017 at 02:46:37 PM by jsonesen
- Description modified (diff)
comment:8 in reply to: ↑ 7 Changed on 12/22/2017 at 04:23:03 PM by kzar
- Cc kzar removed
Replying to jsonesen:
@kzar
I am not sure if the sync script should be changed or if the list_locales function in sources.py should be changed here, I suppose if Julian does'nt want to manually add new directories then it would be an new feature to the sync script, what do you think?
The sync script IMO, probably the configure_locales function but it has been some time since I worked on this.
comment:9 Changed on 09/17/2019 at 12:27:03 PM by kvas
Dear stakeholders of this ticket,
I'm cleaning up Sitescripts tickets in Trac due to its phase out. This is one of the tickets that I could not myself close or move, so I need your input on it.
Please let me know if this ticket is still relevant for you and we can then discuss where it should be moved. If you think that this ticket is no longer relevant, you can write a comment explaining this or just ignore this message.
If I see now comments in the ticket on October 14, I will close it as rejected.
Best regards,
Vasily
@julian
Should the sync script now just pull new upstream locales into the project directory without any additional steps from you (ie creating directories etc)?
@kzar
I am not sure if the sync script should be changed or if the list_locales function in sources.py should be changed here, I suppose if Julian does'nt want to manually add new directories then it would be an new feature to the sync script, what do you think?