Opened on 09/25/2017 at 03:23:27 PM
Closed on 09/28/2017 at 09:31:41 PM
#5776 closed change (fixed)
Update adblockpluscore dependency to d4ed3916793a
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
With #5728, usage of Service.vc.compare() has been removed from adblockpluscore, causing the polyfill in lib/compat.js being unused. There is some other dead code in that script as well.
With #5797, obsolete arguments have been removed from the ElemHideEmulation constructor.
What to change
- Update adblockpluscore dependency to d4ed3916793a.
- Remove any dead code from lib/compat.js.
- Adapt usage of ElemHideEmulation for changes in #5797.
Attachments (0)
Change History (4)
comment:1 Changed on 09/25/2017 at 03:24:33 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 09/27/2017 at 09:22:10 PM by sebastian
- Description modified (diff)
- Summary changed from Update adblockpluscore dependency and remove dead code from lib/compat.js to Update adblockpluscore dependency to d4ed3916793a
comment:3 Changed on 09/28/2017 at 09:30:55 PM by abpbot
comment:4 Changed on 09/28/2017 at 09:31:41 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5776 - Updated adblockpluscore dependency to d4ed3916793a