Opened on 10/23/2017 at 09:40:31 PM
Closed on 03/26/2018 at 10:26:36 AM
#5907 closed change (fixed)
Fix new abp.org navbar on scroll up
| Reported by: | juliandoucette | Assignee: | Yael |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | ire, wpsee, jeen, Yael | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by juliandoucette)
Background
See spec.
What to change
Fix the navbar top when scrolled down the page and scrolling upwards.
Attachments (0)
Change History (14)
comment:1 follow-up: ↓ 2 Changed on 10/23/2017 at 09:41:44 PM by juliandoucette
- CC Ire because this feature may be desirable in website-defaults and help-centre
- P4 because this may not get done before adblockplus.org 2.0.0 completes
comment:2 in reply to: ↑ 1 Changed on 10/24/2017 at 07:37:04 AM by ire
Replying to juliandoucette:
- CC Ire because this feature may be desirable in website-defaults and help-centre
+1
- P4 because this may not get done before adblockplus.org 2.0.0 completes
Ack.
comment:3 follow-up: ↓ 4 Changed on 10/26/2017 at 12:09:27 PM by juliandoucette
@ire do you think we should block this with #5635?
comment:4 in reply to: ↑ 3 Changed on 10/26/2017 at 12:42:25 PM by ire
Replying to juliandoucette:
@ire do you think we should block this with #5635?
Yes I think that makes sense.
We should probably create a separate issue to add this functionality to website-defaults as well since #5635 isn't providing support for it.
comment:5 Changed on 11/22/2017 at 03:40:35 PM by juliandoucette
- Cc wpsee jeen added
- Description modified (diff)
- Priority changed from P4 to P3
@Jeen I think that this functionality is less important than the content updates. Do you agree?
comment:6 Changed on 11/27/2017 at 05:39:25 PM by juliandoucette
- Ready set
comment:7 Changed on 01/30/2018 at 06:51:54 PM by juliandoucette
- Milestone adblockplus.org 2.0.0 deleted
Milestone adblockplus.org 2.0.0 deleted
comment:8 Changed on 02/21/2018 at 01:04:28 PM by juliandoucette
(Jeen agreed)
comment:9 Changed on 02/21/2018 at 01:04:55 PM by juliandoucette
- Cc Yael added
comment:10 Changed on 02/21/2018 at 01:05:25 PM by juliandoucette
- Owner set to Yael
- Review URL(s) modified (diff)
comment:11 Changed on 02/21/2018 at 01:05:32 PM by juliandoucette
- Status changed from new to reviewing
comment:12 Changed on 03/01/2018 at 12:17:51 PM by abpbot
A commit referencing this issue has landed:
Issue 5907 - Made navbar fixed and hide/show on scroll
comment:13 Changed on 03/01/2018 at 06:21:12 PM by abpbot
A commit referencing this issue has landed:
Issue 5907 - Fixed locale menu and spacing of blog affected by 84ac72993b9d
comment:14 Changed on 03/26/2018 at 10:26:36 AM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
