Opened on 10/24/2017 at 02:20:35 PM
Closed on 11/13/2017 at 02:29:12 PM
Last modified on 06/05/2018 at 11:11:55 PM
#5920 closed change (fixed)
Remove the requirement for specifying --with-adjust-sdk-keyfile in mozconfig
| Reported by: | diegocarloslima | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.4.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Background
Mozilla made some changes related to the MOZ_NATIVE_DEVICES and MOZ_INSTALL_TRACKING flags (More info here). With that, it now requires the Adjust SDK keyfile to be specified in mozconfig when both flags are enabled, otherwise it will fails with the message: ERROR: You must specify --with-adjust-sdk-keyfile=/path/to/keyfile when building with MOZ_INSTALL_TRACKING=1
Even though we can still build the project by adding ac_add_options --with-adjust-sdk-keyfile="$topsrcdir/mobile/android/base/adjust-sdk-sandbox.token" in mozconfig, we currently don't want to have this as a mandatory configuration, since we're not using Adjust SDK.
What to change
Either add a logic that specifies --with-adjust-sdk-keyfile when its not explicitly defined in mozconfig or remove the logic that throws an error (if that doesn't bring any collateral effect).
Hints for testers
This is a build issue
Attachments (0)
Change History (6)
comment:1 Changed on 11/06/2017 at 11:45:12 AM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
comment:2 Changed on 11/13/2017 at 02:28:49 PM by abpbot
comment:3 Changed on 11/13/2017 at 02:29:12 PM by diegocarloslima
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed on 06/05/2018 at 11:11:55 PM by traynard
- Verified working set
A commit referencing this issue has landed:
Issue 5920 - Remove the requirement for specifying --with-adjust-sdk-keyfile in mozconfig