Opened on 10/24/2017 at 02:29:34 PM
Closed on 04/12/2018 at 11:49:54 AM
#5921 closed change (invalid)
Update buildtools dependency in adblockplusui to resolve a npm related regression
Reported by: | tlucas | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | kzar, sebastian, oleksandr, greiner, saroyanm | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by tlucas)
Background
The list of changes for buildtools imported by this is:
4d26be1c438e | Noissue - Use sets in build.py were appropriate | Tristan Lucas |
The relevant changes are #5939 (in order to properly synchronize translations), #5895 (preventing undesired output on automation servers), #5857 (resolves npm dependencies if they previously failed) and #5856 (prevents the creation of a npm-version dependent package-lock.json).
What to change
- Change the buildtools dependency to match the respective revision, after #5913 has landed.
hg | git |
39a589de5c18 | 0373bbf |
- Make sure to include the newer version of ensure_dependencies.py
Hints for testers
When trying to build a package in adblockpluschrome, you might have to clean up buidtools in adblockplusui (e.g. delete the folders) - further information can be found in #5856.
Attachments (0)
Change History (6)
comment:1 Changed on 10/24/2017 at 02:34:57 PM by tlucas
- Blocking 5922 added
comment:2 Changed on 10/25/2017 at 04:13:49 PM by kzar
- Blocking 5922 removed
comment:3 Changed on 10/27/2017 at 09:36:22 AM by tlucas
- Blocked By 5913 removed
- Cc trev added
- Description modified (diff)
comment:5 Changed on 12/21/2017 at 11:26:28 AM by fhd
- Cc trev removed
comment:6 Changed on 04/12/2018 at 11:49:54 AM by tlucas
- Resolution set to invalid
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
The mentioned updates are already included.