Opened on 02/26/2018 at 06:42:33 AM
Closed on 02/28/2018 at 12:30:23 PM
#6418 closed defect (fixed)
Override `onShowFileChooser` method
Reported by: | asmirnov | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Libadblockplus-Android | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Android | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
We've introduced internal WebChromeClient impl to handle some events required for ad blocking implementation. However we did not override onShowFileChooser (https://developer.android.com/reference/android/webkit/WebChromeClient.html#onShowFileChooser(android.webkit.WebView, android.webkit.ValueCallback<android.net.Uri[]>, android.webkit.WebChromeClient.FileChooserParams) available since API 21). At the moment it prevents file choosing (reported by partner) file default method definition just returns false.
How to reproduce
- Run the app
- Navigate to any webpage that requires file choosing
- Make sure file chooser dialog is not shown.
...
Observed behaviour
File chooser dialog is not shown
Expected behaviour
External client method should be invoked (if external listener is provided). Default methods to be called otherwise.
Attachments (0)
Change History (3)
comment:1 Changed on 02/26/2018 at 06:47:32 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 02/28/2018 at 12:29:58 PM by abpbot
comment:3 Changed on 02/28/2018 at 12:30:23 PM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Some commits referencing this issue have landed: