Opened on 03/12/2014 at 09:13:32 AM

Closed on 07/23/2014 at 12:51:22 PM

Last modified on 07/31/2014 at 08:37:32 AM

#65 closed change (fixed)

[ABP IE 1.1 cleanup] Fix the approach used by ieFirstRun.js

Reported by: trev Assignee: oleksandr
Priority: P3 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr@adblockplus.org Blocked By:
Blocking: #58 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4859491858251776/

Description

Background

See #58.

What to change

Fix the approach used by ieFirstRun.js - ​http://codereview.adblockplus.org/11276031/diff/1/html/static/js/ieFirstRun.js#newcode49

Attachments (0)

Change History (12)

comment:1 Changed on 03/12/2014 at 09:39:13 AM by philll

  • Blocking 58 added

comment:2 Changed on 03/12/2014 at 03:30:14 PM by trev

  • Reporter changed from philll to trev

comment:3 Changed on 03/13/2014 at 12:47:48 AM by fhd

  • Priority changed from Unknown to P3
  • Status changed from new to accepted

comment:4 Changed on 03/13/2014 at 12:48:59 AM by fhd

  • Owner oleksandr deleted
  • Status changed from accepted to assigned

comment:5 Changed on 03/13/2014 at 01:00:37 AM by fhd

  • Status changed from assigned to accepted

comment:6 Changed on 03/21/2014 at 09:11:02 AM by philll

  • Status changed from accepted to new

comment:7 Changed on 03/21/2014 at 04:59:47 PM by oleksandr

  • Cc oleksandr@adblockplus.org added
  • in_progress set to 0
  • Owner set to oleksandr
  • Ready unset
  • Review URL(s) modified (diff)
  • Status changed from new to assigned

comment:8 Changed on 04/30/2014 at 07:51:15 AM by philll

  • Ready set

comment:9 Changed on 04/30/2014 at 09:50:33 AM by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:10 Changed on 07/03/2014 at 12:21:53 PM by oleksandr

  • Platform set to Unknown
  • Status changed from new to reviewing

comment:11 Changed on 07/23/2014 at 12:51:22 PM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed on 07/31/2014 at 08:37:32 AM by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from oleksandr.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.