Opened on 04/23/2018 at 02:28:54 PM
Closed on 05/04/2018 at 12:04:20 PM
Last modified on 07/05/2018 at 12:02:30 PM
#6610 closed change (fixed)
Use inline style for -abp-properties if there's no tabs.removeCSS support
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | circumvention |
| Cc: | hfiguiere, kzar, sergz, amrmak, arthur | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mjethani)
Background
With revision ae47c9d78ac7 in adblockpluschrome we stopped creating a shadow root on Chrome 66+ and Firefox. On Chrome 66 in particular, this makes -abp-properties easier to circumvent, because we are not using user style sheets for this type of filter for lack of tabs.removeCSS (#6422). In order to mitigate this, we should switch to using inline style="display: none !important" for -abp-properties as well.
What to change
In lib/content/elemHideEmulation.js always prefer inline styles for all types of selectors unless useInlineStyles is set to false.
Attachments (0)
Change History (9)
comment:1 Changed on 04/23/2018 at 02:29:19 PM by mjethani
- Cc hfiguiere kzar sergz added
comment:2 Changed on 04/23/2018 at 02:31:22 PM by amrmak
- Cc amrmak added
comment:3 Changed on 04/23/2018 at 02:33:22 PM by arthur
- Cc arthur added
comment:6 Changed on 05/04/2018 at 12:03:07 PM by abpbot
comment:7 Changed on 05/04/2018 at 12:04:20 PM by mjethani
- Resolution set to fixed
- Status changed from new to closed
Sorry, I landed the change for this, but this is not set to ready. Can I close this?
comment:8 Changed on 05/04/2018 at 12:04:40 PM by mjethani
- Owner set to mjethani
comment:9 Changed on 07/05/2018 at 12:02:30 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Filters using abp-properties use inline styles in browsers where tab.removeCSS is not supported.
ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7
A commit referencing this issue has landed:
Issue 6610 - Prefer inline style for :-abp-properties()