Opened on 04/23/2018 at 03:16:54 PM
Closed on 04/24/2018 at 04:22:48 PM
#6611 closed change (fixed)
createNightlies overwrites adblockplusfirefox.xpi
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, arthur | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In #6371, #6523 and #6560, we switched the hosting of development builds for Adblock Plus for Firefox to a self hosted solution.
Currently, between uploading a build for signing to AMO and downloading the signed .xpi from AMO, an unsigned version is stored on the server's drive ( and also listed on https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/ )
What to change
- Let createNightlies.py in abpssembly not write any unsigned build for Adblock Plus for Firefox to the configured devbuild-folder (in order to not overwrite any existing builds)
- Delete any created .xpi after uploading to AMO succeeded, but keep a copy of that file as "failed.xpi" in the in sitescripts.ini - extensions configured root-folder, for debugging purposes when the upload fails.
Attachments (0)
Change History (5)
comment:1 follow-up: ↓ 2 Changed on 04/24/2018 at 10:06:08 AM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:2 in reply to: ↑ 1 Changed on 04/24/2018 at 12:57:46 PM by tlucas
- Owner set to tlucas
Replying to sebastian:
These changes seem reasonable, but it doesn't explain to me why https://adblockplus.org/devbuilds/adblockplusfirefox/00latest.xpi still gives an unsinged build. Shouldn't a signed build have been downloaded from AMO (replacing the unsigned build) meanwhile?
The flow (currently is)
Cron create:
1) build .xpi to devbuilds/adblockplusfirefox
2) upload .xpi to AMO
3) add to downloads-lockfile
Cron download:
3) download .xpi from AMO
4) remove from downloads-lockfile
5) update symlinks in devbuilds/adblockplusfirefox
6) write new index
Cron group 1 (the one that succeeded) successfully ran through all 6 steps, after finishing the new signed build was available
Cron group 2 failed at step 2 - at that time the unsigned build was already written over the previously signed .xpi (due to the same version, hence filename) -> nothing was added to the downloads-lockfile -> nothing was downloaded -> symlinks have not been updated.
comment:4 Changed on 04/24/2018 at 04:22:22 PM by abpbot
A commit referencing this issue has landed:
Issue 6611 - don't keep unsigned .xpi files
comment:5 Changed on 04/24/2018 at 04:22:48 PM by tlucas
- Resolution set to fixed
- Status changed from new to closed
These changes seem reasonable, but it doesn't explain to me why https://adblockplus.org/devbuilds/adblockplusfirefox/00latest.xpi still gives an unsinged build. Shouldn't a signed build have been downloaded from AMO (replacing the unsigned build) meanwhile?