Opened on 05/29/2018 at 03:15:10 PM

Closed on 05/29/2018 at 03:39:21 PM

#6706 closed change (fixed)

Make "build.py updatepsl" encode domains as Punycode

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29793567

Description

Background

With #6647, we started to match domains encoded as Punycode (instead of Unicode). However, the build.py updatepsl command is still encoding the generated list of public domain suffixes in Unicode, causing third-party checks for affected domains to give the wrong result.

What to change

Adapt the updatepsl command to encode the domains in lib/publicSuffixList.js as Punycode.

Attachments (0)

Change History (3)

comment:1 Changed on 05/29/2018 at 03:18:01 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/29/2018 at 03:38:52 PM by abpbot

A commit referencing this issue has landed:
​Issue 6706 - Make "build.py updatepsl" encode domains as Punycode

comment:3 Changed on 05/29/2018 at 03:39:21 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.