Opened on 05/29/2018 at 03:47:25 PM
Closed on 07/17/2018 at 09:17:59 AM
#6707 closed change (fixed)
Make the generated malware domain filter list encode domains as Punycode
Reported by: | sebastian | Assignee: | atudor |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kvas, tlucas, sebastian, atudor | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Since #6647 (also see the related devbuild announcement), we expect domains in filters being encoded as Punycode (instead of Unicode). However, the generated malware domain list still encodes domains as Unicode. Hence any filter containing an internationalized domain in the malware domain list won't have any effect in Adblock Plus 3.2 (and above).
What to change
Make the generated malware domain filter list encode domains as Punycode.
Attachments (0)
Change History (6)
comment:1 Changed on 05/31/2018 at 02:29:06 PM by kvas
- Cc sebastian added
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 05/31/2018 at 03:28:36 PM by sebastian
Yeah, before Adblock 3.2, filters with domains given in Punycode won't have any effect, while starting with Adblock Plus 3.2, filters with internationalized domains in Unicode won't have any effect.
So if this change would be deployed close to the Adblock Plus 3.2 release, this would minimize scenarios in which filters don't work as expected. But IMO its not important enough to justify any hassle making sure this change gets deployed at the day of the release.
comment:3 Changed on 07/09/2018 at 09:47:06 AM by atudor
- Cc atudor added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 07/09/2018 at 09:57:27 AM by tlucas
- Owner set to atudor
comment:5 Changed on 07/17/2018 at 08:45:15 AM by abpbot
A commit referencing this issue has landed:
Issue 6707 - Make the generated malware domain filter list encode domains as Punycode
comment:6 Changed on 07/17/2018 at 09:17:59 AM by atudor
- Resolution set to fixed
- Status changed from reviewing to closed
@sebastian: are there any timing requirements for this issue? Namely, does it have to be deployed together with ABP 3.2 (which would be the case if ABP currently doesn't understand Punycode) or can it be deployed as soon as done?