Opened on 06/01/2018 at 06:02:23 PM
Closed on 06/01/2018 at 06:15:50 PM
Last modified on 08/21/2018 at 10:32:32 AM
#6721 closed change (fixed)
Update buildtools dependency to 9a56d76cd951
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-3.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6621 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
With #6647, we started to match domains encoded as Punycode (instead of Unicode). The build.py updatepsl command has been adapted accordingly in #6706.
In #6621, we want to bundle a different version of the io module dependent on the target platform. Support for this has been added to buildtools with #6625.
Included changes in buildtools
The list of changes imported by this is:
| Ticket | Summary | Component |
|---|---|---|
| #6706 | Make "build.py updatepsl" encode domains as Punycode | Automation |
| #6625 | Enable module switching in webpack, parametrized by metadata.* | Automation |
| a8b5bbe92c0a | Noissue - Adapt best practices for trailing commas | Sebastian Noack |
What to change
Update the buildtools dependency to:
| mercurial | git |
| 9a56d76cd951 | deb79b0 |
Hints for testers
- Make sure that after running build.py updatepsl, there will be no non-ascii charecter in lib/publicSuffixList.js and that internationalized domains are encoded in valid Punycode.
- Make sure that these changes don't cause any difference in the generated builds.
Attachments (0)
Change History (4)
comment:1 Changed on 06/01/2018 at 06:10:48 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 06/01/2018 at 06:15:04 PM by abpbot
comment:3 Changed on 06/01/2018 at 06:15:50 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from reviewing to closed
comment:4 Changed on 08/21/2018 at 10:32:32 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
This looks to be working as expected. Internationalized domains are encoded to Punycode and generated builds work.
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6721 - Update buildtools dependency to 9a56d76cd951