Opened on 08/29/2018 at 05:48:47 PM
Closed on 08/30/2018 at 02:32:59 PM
#6906 closed defect (fixed)
Source archives contain wrong version number
| Reported by: | sebastian | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | tlucas | Blocked By: | |
| Blocking: | #6910 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by tlucas)
How to reproduce
Run .build.py release -t chrome -t gecko -k adblockpluschrome.pem <version> from within adblockpluschrome.
Be careful to not actually release any new version
You can mock a suitable environment by following This guide
You will find the previous generated source archives in the downloads repository.
Observed behaviour
The version in the metadata.chrome file in the generated source archives, points to the previous version before the release is performed, hence does the version of the builds generated from the source archive.
Expected behaviour
Builds generated from a source archive must have the correct version, corresponding to the version of the source code.
Attachments (0)
Change History (6)
comment:1 Changed on 08/30/2018 at 10:34:47 AM by tlucas
- Owner set to tlucas
comment:3 Changed on 08/30/2018 at 01:12:56 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/30/2018 at 01:27:27 PM by tlucas
- Blocking 6910 added
comment:5 Changed on 08/30/2018 at 02:32:25 PM by abpbot
comment:6 Changed on 08/30/2018 at 02:32:59 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6906 - pack source archives with the correct version