Opened on 08/29/2018 at 05:56:11 PM

Closed on 09/06/2018 at 11:10:43 AM

Last modified on 10/25/2018 at 10:33:15 AM

#6907 closed change (fixed)

Adapt code to ensure compatibility with latest changes to filter notifier

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6933 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/103

Description (last modified by greiner)

Background

See ​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/181

What to change

See ​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/181

Hints for testers

  • Anti-adblock notification should no longer be active (i.e. show up when visiting a web page corresponding to a domain listed in the Anti-adblock warning removal list) after removing the according filter list.
  • Anti-adblock notification should be active after adding the filter list again.
  • Adding, removing and disabling a filter list should update the UI in the settings page accordingly.

Attachments (0)

Change History (7)

comment:1 Changed on 09/04/2018 at 05:05:54 PM by greiner

  • Owner set to greiner

comment:2 Changed on 09/04/2018 at 05:08:21 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/04/2018 at 06:23:23 PM by greiner

  • Description modified (diff)

Added hints for testers.

comment:4 Changed on 09/06/2018 at 11:10:43 AM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Done: ​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/ac733d953352ca9cb4cf66f4b9649e90c5e3ddec

comment:5 Changed on 09/06/2018 at 11:17:12 AM by greiner

  • Blocking 6933 added; 6892 removed

comment:6 Changed on 09/11/2018 at 01:13:45 PM by abpbot

A commit referencing this issue has landed:
​Issue 6907 - Renamed FilterNotifier to filterNotifier

comment:7 Changed on 10/25/2018 at 10:33:15 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Looks to be working as described.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.