Opened on 12/09/2018 at 11:47:22 AM
Closed on 12/12/2018 at 08:15:05 AM
Last modified on 02/21/2019 at 08:55:06 AM
#7162 closed change (fixed)
Add isWhitelisted method to CombinedMatcher
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mjethani)
Background
In #6940, we made the whitelist property of CombinedMatcher private. lib/filterComposer.js in adblockpluschrome still needs a way to find out if a URL is whitelisted.
What to change
Add a isWhitelisted method to CombinedMatcher. It should call this._whitelist.matchesAny and return a boolean value.
Hints for testers
This is some new code in adblockpluscore, there's nothing to test via the extension (but see #7054).
Attachments (0)
Change History (5)
comment:1 Changed on 12/09/2018 at 11:57:55 AM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/12/2018 at 08:13:17 AM by abpbot
comment:3 Changed on 12/12/2018 at 08:15:05 AM by mjethani
- Description modified (diff)
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 02/07/2019 at 03:23:57 AM by abpbot
A commit referencing this issue has landed:
Issue 7162 - Add isWhitelisted method to CombinedMatcher
comment:5 Changed on 02/21/2019 at 08:55:06 AM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7162 - Add isWhitelisted method to CombinedMatcher