Opened on 12/11/2018 at 01:10:03 PM
Closed on 03/18/2019 at 04:13:31 PM
Last modified on 03/19/2019 at 12:04:19 AM
#7163 closed change (fixed)
Create test page for basic generic hide and block filters
Reported by: | Ross | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Websites | Keywords: | |
Cc: | sebastian, kzar | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/9 |
Description (last modified by Ross)
Background
There are no test pages for testing the generic hide and block filters.
What to change
For generic hide:
- Add a test page with two target elements.
- Element 1 is hidden with a specific filter. Element 2 is hidden with a generic filter.
- Add a filter to add exceptions to the generic element.
- Add the same elements, but inside a frame, for testing frame behaviour.
For generic block:
- Add a test page with two target images.
- Image 1 is hidden with a specific filter ($domain=). Image 2 is hidden with a generic filter.
- Add a filter to add exceptions to the generic image.
- Add the same images, but inside a frame, for testing frame behaviour.
Attachments (0)
Change History (6)
comment:1 Changed on 03/18/2019 at 10:11:48 AM by ubernitt
comment:2 Changed on 03/18/2019 at 10:27:23 AM by Ross
- Cc sebastian added
- Description modified (diff)
- Ready set
comment:3 Changed on 03/18/2019 at 10:27:46 AM by Ross
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/18/2019 at 04:11:47 PM by abpbot
A commit referencing this issue has landed:
Issue 7163 - Create test pages for generic hide and block filters
comment:5 Changed on 03/18/2019 at 04:13:31 PM by Ross
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
This is a duplicate of #7351, additional info may be found there