Opened on 01/31/2019 at 12:01:42 PM
Closed on 02/01/2019 at 01:40:31 AM
Last modified on 10/08/2019 at 06:06:30 PM
#7249 closed change (fixed)
Update adblockplusui dependency to 841a20f6f3ae (release-2018-5.-7)
| Reported by: | greiner | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.5-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | wspee, sebastian | Blocked By: | #7221 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
This imports the following changes:
| Ticket | Status | Resolution | Summary | Component | Owner |
|---|---|---|---|---|---|
| #7027 | closed | fixed | Adapt code to work with latest changes to FilterStorage.subscriptions | User-Interface | greiner |
| #7150 | closed | fixed | Adapt code to work with latest changes to Subscription.prototype.filters | User-Interface | greiner |
| #7151 | closed | fixed | Adapt code to work with renamed FilterStorage | User-Interface | greiner |
| #7221 | closed | fixed | Manual filter list update broken in next branch | User-Interface | greiner |
All of the above changes merely adapt for changes in adblockpluscore and should not change any behavior.
What to change
Change adblockplusui dependency to hg:841a20f6f3ae git:0a673ad
Hints for testers
See hints for testers section in the individual tickets.
Attachments (0)
Change History (8)
comment:1 Changed on 01/31/2019 at 12:04:07 PM by greiner
- Blocked By 7221 added
- Cc wspee sebastian added
- Description modified (diff)
comment:2 Changed on 01/31/2019 at 12:10:06 PM by greiner
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:3 Changed on 01/31/2019 at 05:28:17 PM by greiner
- Description modified (diff)
- Summary changed from Update adblockplusui dependency to TBA (release-2018-5.-7) to Update adblockplusui dependency to 841a20f6f3ae (release-2018-5.-7)
comment:4 Changed on 02/01/2019 at 01:36:16 AM by sebastian
- Description modified (diff)
- Owner set to sebastian
- Priority changed from Unknown to P2
- Ready set
comment:5 Changed on 02/01/2019 at 01:37:32 AM by abpbot
A commit referencing this issue has landed:
Issue 7249 - Updated adblockplusui dependency to 841a20f6f3ae
comment:6 Changed on 02/01/2019 at 01:40:31 AM by sebastian
- Resolution set to fixed
- Status changed from new to closed
comment:7 Changed on 02/01/2019 at 10:22:49 AM by webdschool
spam
Last edited on 10/08/2019 at 06:06:30 PM
by kzar
comment:8 Changed on 02/14/2019 at 03:24:25 PM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
Added commit hashes.