Opened on 09/22/2014 at 04:28:33 AM
Closed on 09/22/2014 at 01:40:37 PM
Last modified on 10/01/2014 at 11:43:48 AM
#1424 closed change (fixed)
Update libadblockplus-binaries dependency in the adblockplusandroid repository to revision 6f79af14ad4e
| Reported by: | fhd | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Android-1.3 |
| Module: | Adblock-Plus-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #98, #985 | Platform: | Android |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by fhd)
Background
The libadblockplus-binaries dependency is currently at 7b68c61243c5, which is libadblockplus revision 1ae1b8d23f10.
The following issues have been resolved since then:
What to change
The libadblockplus-binaries dependency should be updated to 6f79af14ad4e, which is libadblockplus revision 46f045921142.
Hints for testers
The only change that should be able to cause regressions is #1286. This affects filter matching, so be sure to test that adblocking works for various resource types.
Attachments (0)
Change History (11)
comment:4 Changed on 09/22/2014 at 04:55:38 AM by fhd
- Blocking 985 added
comment:5 Changed on 09/22/2014 at 04:56:10 AM by fhd
- Blocking 985 removed
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/22/2014 at 04:56:24 AM by fhd
- Blocking 985 added
comment:7 Changed on 09/22/2014 at 07:22:40 AM by philll
comment:8 Changed on 09/22/2014 at 07:53:05 AM by fhd
Yes. As I said in the review, the libadblockplus and libadblockplus-binaries revisions referred to are not pushed yet. Not brilliant, but I really wanted to move on to make sure Android updates work again ASAP.
comment:9 Changed on 09/22/2014 at 01:40:37 PM by fhd
- Description modified (diff)
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 09/22/2014 at 01:42:03 PM by fhd
comment:11 Changed on 10/01/2014 at 11:43:48 AM by fhd
- Milestone set to Adblock-Plus-for-Android-1.3
I guess, #1296 should be closed (and thus pushed) before this here is going to land?!