Opened on 10/21/2014 at 01:53:13 PM
Closed on 04/30/2015 at 04:20:56 AM
Last modified on 05/20/2015 at 02:22:39 PM
#1489 closed change (fixed)
Enable pre-configurable properties in Firefox
| Reported by: | sebastian | Assignee: | fhd |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | growth, large-scale-deployments |
| Cc: | mapx, simona, sebastian, trev | Blocked By: | |
| Blocking: | #542, #2347 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by fhd)
Background
In order to help administrators to deploy Adblock Plus in managed networks, we introduce a mechanism to enable pre-configurable properties.
What to change
On Firefox, we can use prefs for this, those can be set externally. However, Adblock Plus is currently overwriting default prefs - we shouldn't do that for preconfigured prefs.
Attachments (0)
Change History (26)
comment:1 Changed on 10/21/2014 at 01:54:02 PM by sebastian
- Blocking 206 added
comment:3 Changed on 10/21/2014 at 02:14:59 PM by mapx
- Cc mapx added
comment:5 Changed on 10/22/2014 at 11:32:51 AM by sebastian
- Cc sebastian removed
comment:6 Changed on 10/30/2014 at 01:08:53 PM by simona
- Keywords growth added
comment:7 Changed on 11/21/2014 at 11:55:55 AM by simona
- Cc simona added
comment:8 Changed on 11/21/2014 at 04:15:34 PM by simona
- Keywords large-scale-deployments added
comment:9 Changed on 03/19/2015 at 09:39:44 PM by fhd
- Blocking 206 removed
comment:10 Changed on 03/19/2015 at 10:16:10 PM by fhd
comment:11 Changed on 03/20/2015 at 02:41:38 PM by sebastian
- Blocked By 1487 removed
comment:12 Changed on 03/20/2015 at 02:56:20 PM by sebastian
- Cc sebastian added
- Ready unset
comment:13 Changed on 03/24/2015 at 01:04:19 PM by fhd
- Component changed from Adblock-Plus-for-Firefox to Build-and-Release-Tools
- Description modified (diff)
- Review URL(s) modified (diff)
By now it seems pretty clear to me that this is actually a buildtools issue, changing the component. We're dealing with default prefs in buildtools, we'll have to deal with preconfigured prefs there as well.
Also properly linking the patch I put up for this. Still, not set to Ready - Sebastian should do that if he's fine with the issue.
comment:14 Changed on 03/24/2015 at 01:05:58 PM by fhd
- Owner set to fhd
comment:15 follow-up: ↓ 17 Changed on 03/24/2015 at 01:59:23 PM by fhd
I suppose the major alternative to the preconfigured_defaults pref would be to have preconfigured defaults on a separate branch, e.g. extensions.adblockplus.preconfigured, shouldn't be that much more complicated how I see it.
Which approach would you prefer, Wladimir?
comment:16 Changed on 03/24/2015 at 02:10:10 PM by fhd
- Cc trev added
Wladimir: Oh, asked you something when you weren't even in CC :) Please see above.
comment:17 in reply to: ↑ 15 ; follow-up: ↓ 18 Changed on 04/01/2015 at 07:42:35 AM by trev
Replying to fhd:
I suppose the major alternative to the preconfigured_defaults pref would be to have preconfigured defaults on a separate branch, e.g. extensions.adblockplus.preconfigured, shouldn't be that much more complicated how I see it.
Sounds good to me, we would then also be able to apply the same whitelist approach we have in Chrome right now. So only extensions.adblockplus.preconfigured.suppress_first_run_page would be considered but not extensions.adblockplus.preconfigured.enabled for example. Given that we import the defaults ourselves, it wouldn't be a large change.
Note that I would change the prefs.js file format (and rename the file) while at it - JSON listing the default preferences (without branch name) and a whitelist for preconfigured preferences sounds like a much better idea.
comment:18 in reply to: ↑ 17 Changed on 04/03/2015 at 11:28:07 PM by fhd
Alright, will put up a new patch with this approach.
Replying to trev:
Note that I would change the prefs.js file format (and rename the file) while at it - JSON listing the default preferences (without branch name) and a whitelist for preconfigured preferences sounds like a much better idea.
Sounds good, but I'd prefer to keep this patch minimal if possible. I've prepared one that'll introduce a third parameter to pref() that marks preconfigurable prefs.
comment:19 Changed on 04/03/2015 at 11:28:39 PM by fhd
- Ready set
- Status changed from new to reviewing
comment:20 Changed on 04/18/2015 at 09:05:38 PM by fhd
- Blocking 2347 added
comment:21 Changed on 04/30/2015 at 04:20:44 AM by fhd
This has landed. Note that there's a follow-up for making the suppress_first_run_page pref preconfigurable: #2439
comment:22 Changed on 04/30/2015 at 04:20:56 AM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
comment:23 Changed on 04/30/2015 at 04:22:35 AM by fhd
- Blocking 2347 removed
comment:24 Changed on 04/30/2015 at 04:23:10 AM by fhd
- Blocking 2347 added
comment:25 Changed on 05/07/2015 at 12:03:21 PM by fhd
Was pushed as: https://hg.adblockplus.org/buildtools/rev/e4ebf43fa300
comment:26 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Firefox already has a mechanism for pre-configuring prefs.
It's already possible to preconfigure ABP to some extent this way. However, users can't really change prefs set this way - those will be overwritten on each startup.
Pre-configuring the default prefs seems like a better option. However, currently ABP is overwriting the default prefs - for this to work we need to leave default prefs that have already been set alone.
I've put up a patch for that. However, so far we don't agree on this being the best approach.