Opened on 04/18/2015 at 09:04:51 PM

Closed on 05/06/2015 at 07:25:30 AM

Last modified on 06/30/2015 at 09:33:59 AM

#2347 closed change (fixed)

Stop the ABP first run page from showing up in Adblock Browser for Android

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords: 2015q2
Cc: Blocked By: #206, #1489, #2439, #2451
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5233612492374016/

Description (last modified by fhd)

Background

The ABP first run page is currently being shown on the first startup, with a few seconds delay. Adblock Browser has the first run slides, so showing the ABP first run page would be redundant.

What to change

Stop the ABP first run page from showing up in Adblock Browser for Android.

Attachments (0)

Change History (15)

comment:1 Changed on 04/18/2015 at 09:05:38 PM by fhd

  • Blocked By 206, 1489 added

comment:2 Changed on 04/18/2015 at 09:07:58 PM by fhd

Once #1489 has landed, this is as simple as settings extensions.adblockplus.preconfigured.suppress_first_run_page to true in mobile.js.

comment:3 Changed on 04/20/2015 at 07:38:23 AM by philll

  • Description modified (diff)
  • Summary changed from Stop the ABP first run page from showing up to Stop the ABP first run page from showing up in Adblock Browser for Android

comment:4 Changed on 04/20/2015 at 08:13:32 AM by fhd

  • Description modified (diff)

comment:5 Changed on 04/30/2015 at 04:22:35 AM by fhd

  • Blocked By 2439 added; 1489 removed

comment:6 Changed on 04/30/2015 at 04:23:10 AM by fhd

  • Blocked By 1489 added

comment:7 Changed on 05/04/2015 at 07:47:38 PM by fhd

  • Owner set to fhd

comment:8 Changed on 05/04/2015 at 08:15:02 PM by fhd

  • Blocked By 2451 added

comment:9 Changed on 05/04/2015 at 08:19:16 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed on 05/06/2015 at 07:25:30 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed on 05/06/2015 at 07:29:24 AM by fhd

  • Milestone set to Flux-next

comment:12 Changed on 05/06/2015 at 05:03:08 PM by fhd

  • Keywords 2015q2 added

comment:13 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:14 Changed on 05/22/2015 at 09:33:21 PM by fhd

Was pushed as: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/a47553331230

comment:15 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.