Opened on 12/18/2014 at 09:13:09 AM
Closed on 01/20/2016 at 12:37:43 PM
#1718 closed change (duplicate)
Limit workaround for Chrome bug breaking Flash videos to Chrome 38-40
Reported by: | sebastian | Assignee: | sebastian |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Platform | Keywords: | externaldependency |
Cc: | trev | Blocked By: | |
Blocking: | Platform: | Unknown | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Chrome 38-40 mistakenly identified requests loading <object> elements like Flash, and requests initiated by those third-party plugins, with the type other instead object.
We worked around that issue, by pretending that every request of the type other is actually of the type object on Chrome 38 and higher as implemented by #1372 and #1593. However, the Chrome bug responsible got recently fixed, and that workaround isn't needed anymore on Chrome 41 and above.
What to change
Limit workaround for Chrome bug 410382 to the affected versions (i.e. Chrome 38-40), relying again on the webRequest API to distinguish the request types other and object.
Attachments (0)
Change History (4)
comment:1 Changed on 12/18/2014 at 09:14:02 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/21/2014 at 05:00:47 PM by sebastian
- Cc trev added
- Keywords externaldependency added
- Ready unset
comment:4 Changed on 01/20/2016 at 12:37:43 PM by sebastian
- Resolution set to duplicate
- Status changed from reviewing to closed
- Tester set to Unknown
Chrome bug 410382 got finally fixed in Chrome 49. The workaround has been adapted with #3453.
The fix for https://crbug.com/410382 has recently been reverted. :(