Opened on 12/18/2014 at 02:23:08 PM

Closed on 12/18/2014 at 02:28:30 PM

Last modified on 12/30/2014 at 02:54:37 AM

#1719 closed change (fixed)

Update buildtools dependency to 6524d2ff188d

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by sebastian)

Background

The fix for an issue where placeholders showed up (#1703) depends on a change in the buildtools (#1704). Moreover, we should update the dependencies for the 1.8.9 release anyway, pulling in following changes:

#1655
Adding the "short_name" to our Chrome manifest
#1704
Don't configure content scripts with "match_about_blank" on Chrome
#1707
Allow importing Chrome-style locales in Firefox extensions
#1709
Allow importing Chrome-style locales in Chrome extensions
#1731
Gujarati translation is imported with wrong locale code from CrowdIn


What to change

Update the "buildtools" submodule to revision 6524d2ff188d.

Hints for testers

  • Make sure that #1703 is fixed (it depends on a change in the buildtools: #1704)
  • Make sure that all translations are still included in the build and used (see #1709 and #1731).

Attachments (0)

Change History (4)

comment:1 Changed on 12/18/2014 at 02:28:30 PM by sebastian

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed on 12/18/2014 at 02:34:14 PM by sebastian

  • Description modified (diff)

comment:3 Changed on 12/28/2014 at 04:11:37 PM by sebastian

  • Description modified (diff)

comment:4 Changed on 12/30/2014 at 02:54:37 AM by sebastian

  • Description modified (diff)
  • Summary changed from Update buildtools dependency to cec64f71eca0 to Update buildtools dependency to 6524d2ff188d

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.