Opened on 12/16/2014 at 09:33:39 PM
Closed on 01/08/2015 at 04:45:22 PM
Last modified on 01/13/2015 at 05:53:45 PM
#1708 closed change (fixed)
Integrate first-run page changes in Chrome/Opera/Safari
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #1663, #1709 | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by trev)
Background
#1663 moves the first-run page into the adblockplusui repository and makes sure asynchronous messaging is being used. We need to start using this implementations in Chrome/Opera/Safari.
What to change
- Add adblockplusui repository as a dependency.
- Make sure all the necessary files as well as localization data are imported (buildtools update required for the latter).
- Implement the required message responders in the adblockpluschrome respository.
Hints for testers
The first-run page needs to be tested completely. The change in #1655 will also be "imported" here, it should have no visible impact (i.e. the extension should stay installable).
Attachments (0)
Change History (7)
comment:1 Changed on 12/16/2014 at 09:35:11 PM by trev
- Blocked By 1709 added
comment:2 Changed on 12/17/2014 at 10:41:28 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 12/30/2014 at 02:04:13 AM by sebastian
comment:5 Changed on 01/08/2015 at 04:45:22 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 01/13/2015 at 05:52:41 PM by sebastian
- Milestone set to Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
comment:7 Changed on 01/13/2015 at 05:53:45 PM by sebastian
- Owner set to trev
Note: See
TracTickets for help on using
tickets.
This will also fix #1741.