Opened on 01/24/2015 at 07:57:29 AM
Closed on 01/24/2015 at 10:46:44 AM
Last modified on 01/24/2015 at 10:49:16 AM
#1866 closed defect (incomplete)
ABP 1.8.10 'Block Element' right-click menu not working on facebook
Reported by: | mapx | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Platform | Keywords: | |
Cc: | sebastian | Blocked By: | |
Blocking: | Platform: | Chrome | |
Ready: | no | Confidential: | no |
Tester: | Verified working: | ||
Review URL(s): |
Description (last modified by mapx)
Environment
windows 7
chrome 40
ABP 1.8.10 or the last 1.8.10.1326
How to reproduce
go to facebook.com
right click on an image
the option "block element" is not present in the context menu
reported in the forum: https://adblockplus.org/forum/viewtopic.php?f=10&t=27649
Attachments (0)
Change History (6)
comment:2 Changed on 01/24/2015 at 09:40:39 AM by sebastian
comment:3 Changed on 01/24/2015 at 10:06:44 AM by mapx
In that case (of OP) is true: he wants to hide some html element (an entire zone) not only an image.
I tried blocking only an image and does not work (the option in the context menu is not present).
When I click the image (to open it) then on the opened image the option will be present.
comment:4 Changed on 01/24/2015 at 10:09:30 AM by mapx
I had an old test FB stuff (saved by some user), and you can see there, right click on the images in the page (scroll down) does not show the block element option
comment:5 Changed on 01/24/2015 at 10:46:44 AM by sebastian
- Resolution set to invalid
- Status changed from new to closed
They use an interesting trick to hide images from the mouse pointer, applying following CSS on the image's parent element:
._4-eo::after { border: 1px solid rgba(0, 0, 0, .1); bottom: 0; content: ''; left: 0; position: absolute; right: 0; top: 0; }
This essentially means that the image will be covered by an invisible pseudo-element. Hence mouse events will be dispatched to the image's parent element instead. Note that not only our "Block element" context menu item is missing, but also the built-in "Save image as" and "Copy Image URL" items.
comment:6 Changed on 01/24/2015 at 10:49:16 AM by mapx
yep, right, "save image as.." is missing, I noted as well ... so, it's normal behaviour. Thanks.
I don't have a Facebook account, but at least on the logged out http://facebook.com/ page, the "Block element" context menu item is shown for images.
It looks like that the OP of that forum thread didn't right-click an image but a container element, we never showed the context menu item for. You have to use "Block element" from the icon popup to block those.